This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Update sub-group mask test #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is updated according spec changes in intel/llvm#4481
vladimirlaz
requested review from
bader,
Pennycook and
romanovvlad
as code owners
|
@Pennycook, please review/approve the PR? |
Pennycook
reviewed
Sep 17, 2021
| res |= (!gmask_gid3[8] || gmask_gid3[9] || !gmask_gid3[10] || | ||
| gmask_gid3[11]) | ||
| << 6; | ||
| marray<unsigned char, 6> mr{1}; |
There was a problem hiding this comment.
Sorry if this is obvious, but why is this a 6?
There was a problem hiding this comment.
Just longer-than-sub_group_mask-can accept.
vladimirlaz
added a commit
to intel/llvm
that referenced
this pull request
Sep 18, 2021
The specification is available under https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/SubGroupMask/SubGroupMask.asciidoc Complementary test changes are available under intel/llvm-test-suite#441, intel/llvm-test-suite#462
|
@Pennycook, could you please approve if you are ok? |
Pennycook
approved these changes
Sep 22, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is updated according spec changes in intel/llvm#4481